/firehol

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireQOS match tcp doesn't do anything #249

Closed
mikenor opened this Issue Aug 8, 2017 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@mikenor @ktsaou
@mikenor

mikenor commented Aug 8, 2017

Using, FireQOS 3.1.3 when I configure a class that has match tcp or match protocol tcp, the resulting tc filter command is missing the appropriate match statement. According to FireQOS debug mode, the resulting tc command is tc filter add dev eth0 parent 1:0 protocol ip prio 10 flowid 1:11. Shouldn't the tc command contain match ip protocol 6 somewhere?

ktsaou added a commit to ktsaou/firehol that referenced this issue Aug 16, 2017

@ktsaou
properly match tcp protocol; fixes #249
Verified
This commit was signed with a verified signature.
@ktsaou ktsaou Costa Tsaousis
GPG key ID: 29CA335889B9A863 Learn about signing commits
55fcfb0
@ktsaou

This comment has been minimized.

Show comment
Hide comment
@ktsaou

ktsaou Aug 16, 2017

Member

Thanks for reporting it.
It seems the GRE patches messed this up.
Fixed it.
Member

ktsaou commented Aug 16, 2017

Thanks for reporting it.
It seems the GRE patches messed this up.
Fixed it.

@ktsaou ktsaou added bug fireqos labels Aug 16, 2017

@ktsaou ktsaou referenced this issue Aug 16, 2017

Merged

Fix FireQoS bugs #251

@ktsaou ktsaou closed this in #251 Aug 18, 2017

@ktsaou

This comment has been minimized.

Show comment
Hide comment
@ktsaou

ktsaou Aug 18, 2017

Member

merged it!
Thank you for reporting it!
Member

ktsaou commented Aug 18, 2017

merged it!
Thank you for reporting it!

philwhineray added a commit that referenced this issue Aug 20, 2017

@philwhineray
Prepare release 3.1.4 
Fixes: #235, #223, #184, #94, #143, #248, #249, #231, #217, #221
571b3b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment