Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FireQOS match tcp doesn't do anything #249

Closed
mikenor opened this issue Aug 8, 2017 · 2 comments · Fixed by #251
Closed

FireQOS match tcp doesn't do anything #249

mikenor opened this issue Aug 8, 2017 · 2 comments · Fixed by #251
Labels
bug fireqos

Comments

@mikenor
Copy link

mikenor commented Aug 8, 2017

Using, FireQOS 3.1.3 when I configure a class that has match tcp or match protocol tcp, the resulting tc filter command is missing the appropriate match statement. According to FireQOS debug mode, the resulting tc command is tc filter add dev eth0 parent 1:0 protocol ip prio 10 flowid 1:11. Shouldn't the tc command contain match ip protocol 6 somewhere?
ktsaou added a commit to ktsaou/firehol that referenced this issue Aug 16, 2017
@ktsaou
properly match tcp protocol; fixes firehol#249
55fcfb0
@ktsaou
Copy link
Member

ktsaou commented Aug 16, 2017

Thanks for reporting it.
It seems the GRE patches messed this up.
Fixed it.

@ktsaou ktsaou mentioned this issue Aug 16, 2017
Merged
@ktsaou
Copy link
Member

ktsaou commented Aug 18, 2017

merged it!
Thank you for reporting it!

philwhineray added a commit that referenced this issue Aug 20, 2017
@philwhineray
Prepare release 3.1.4
571b3b0 
Fixes: #235, #223, #184, #94, #143, #248, #249, #231, #217, #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fireqos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix FireQoS bugs ktsaou/firehol
2 participants
@ktsaou @mikenor