Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amethyst Caves biome uses minecraft:music.overworld.jungle_and_forest which was removed in 1.20 #19

Open
alcatrazEscapee opened this issue Oct 30, 2023 · 0 comments

Comments

@alcatrazEscapee
Copy link

The amethyst caves biome JSON specifies the music sound event as minecraft:music.overworld.jungle_and_forest:

"music": {
"max_delay": 24000,
"min_delay": 12000,
"replace_current_music": false,
"sound": "minecraft:music.overworld.jungle_and_forest"
},

However, this does not exist in 1.20. According to a brief search in Linkie, it seems to have existed in 1.19.4 then removed in 1.20:

In 1.19.4:

image

In 1.20 (and onwards):

image

Due to vanilla's poor codec handling, this field being invalid does not error, as the music field is an optional field. When used with Cyanide, however, this gets promoted to a full error:

[23:16:10] [Render thread/WARN] (Minecraft) Failed to load level data or datapacks, can't proceed with server load
java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Error(s) loading registries:


Errors(s) loading registry minecraft:worldgen/biome:

Optional field "music" was invalid: Failed to get element ResourceKey[minecraft:sound_event / minecraft:music.overworld.jungle_and_forest]
	at: "effects"
	at: worldgen/biome 'profundis:worldgen/biome/amethyst_caves.json'
	at: pack 'fabric'


Errors occurred freezing registries.
These were elements that were referenced, but never defined (or their definition had an error above).

Missing references from the worldgen/biome registry: [
	'profundis:amethyst_caves'
]

This was reported as an issue to Cyanide here: alcatrazEscapee/cyanide#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant