Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git_tag_name on release flow #120

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix git_tag_name on release flow #120

merged 1 commit into from
Mar 9, 2021

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Mar 9, 2021

Since the action trigger is not release, we cannot use github.event.release.tag_name. We use push: tags trigger so we can use $GITHUB_REF (ref).

tarao
tarao approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itchyny LGTM

@itchyny itchyny merged commit 919cc94 into master Mar 9, 2021
@itchyny itchyny deleted the fix-release-git-tag-name branch March 9, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itchyny @tarao