Add throttle config base #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yigarashi-9
commented
Jun 16, 2021
| @@ -0,0 +1,6 @@ | |||
| CREATE TABLE IF NOT EXISTS `queue_throttle` ( | |||
| `name` VARCHAR(255) NOT NULL, | |||
| `max_dispatches_per_second` FLOAT UNSIGNED NOT NULL, | |||
There was a problem hiding this comment.
I think float has enough precison for our purpose.
yigarashi-9
commented
Jun 16, 2021
model/model.go
Outdated
| Name string `json:"name"` | ||
| PollingInterval uint `json:"polling_interval"` | ||
| MaxWorkers uint `json:"max_workers"` | ||
| MaxDispatchesPerSecond float64 `json:"max_dispatches_per_second"` |
There was a problem hiding this comment.
I followed this https://pkg.go.dev/golang.org/x/time/rate#Limit
itchyny
approved these changes
Jun 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to implement throttled queue. I implement schema and model first.