Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must get golang/mock@1.3.0 before run make credits #39

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Must get golang/mock@1.3.0 before run make credits #39

merged 2 commits into from
Aug 26, 2019

Conversation

Sixeight
Copy link
Contributor

@Sixeight Sixeight commented Aug 26, 2019 •
edited

What

  • Make sure dependencies of gocredits when make credits.

Why

  • I got an error like below when trying release next version.
  • We need to install golang/mock@v1.3.0. And go mod installs the library when make release (= go build). But the task depends make credits, then does not found the library at make credits.
  • This bug had introduced: Migrate to Go Modules #32
GO111MODULE=off GOOS= GOARCH= go get github.com/Songmu/gocredits/cmd/gocredits
gocredits -w .
open /go/pkg/mod/github.com/golang/mock@v1.3.0: no such file or directory
make: *** [Makefile:32: credits] Error 1
+status=2

@Sixeight Sixeight self-assigned this Aug 26, 2019
@Sixeight Sixeight added the bug label Aug 26, 2019
@Sixeight Sixeight requested a review from tarao August 26, 2019 04:41
tarao
tarao approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sixeight LGTM except a nit pick.

Makefile Outdated
@@ -29,6 +29,7 @@ release: clean deps credits generate
credits:
GOOS= GOARCH= ${GO} run script/genauthors/genauthors.go > AUTHORS
GO111MODULE=off GOOS= GOARCH= ${GO} get github.com/Songmu/gocredits/cmd/gocredits
go mod tidy # not `go get` to get all the dependencies regardress of OS, architecture and build tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]

Shouldn't it be ${GO} mod tidy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. I'll fix it.

@Sixeight Sixeight merged commit 99b1620 into master Aug 26, 2019
@Sixeight Sixeight deleted the fix-release-task branch August 26, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees

@Sixeight Sixeight

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sixeight @tarao