Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FIREWORQ_DEPS arguments in Dockerfile #59

Merged
merged 2 commits into from
May 11, 2020
Merged

Remove FIREWORQ_DEPS arguments in Dockerfile #59

merged 2 commits into from
May 11, 2020
+6 −17

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented May 8, 2020

Since #32, we don't use glide and the vendor/ directory anymore, and we don't need to make deps beforehand.

tarao
tarao approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@tarao tarao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itchyny LGTM

@itchyny
Copy link
Contributor Author

itchyny commented May 11, 2020

Thank you.

@itchyny itchyny merged commit d929578 into master May 11, 2020
@itchyny itchyny deleted the remove-fireworq-deps branch May 11, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarao tarao tarao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itchyny @tarao