fix(apple): use documents for tempfile - #10019
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with log export functionality on iOS 18.5.0 where the share sheet can no longer access files staged in the temporary directory. The solution is to stage log files in the documents directory instead of the temporary directory.
Key Changes
- Updated the
tempFile()method to use the documents directory instead of the temporary directory for staging log export files - Added comment explaining why the documents directory is required for share sheet compatibility
jamilbk
force-pushed
the
fix/ios-log-export
branch
from
July 26, 2025 13:43
f927ed4 to
533a49e
Compare
jamilbk
enabled auto-merge
July 26, 2025 13:43
thomaseizinger
approved these changes
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, we were using the tempfile directory to stage the log export, and then moving this into place from the share sheet presented to the user.
For some reason, this has stopped working in iOS 18.5.0, and we need to stage the file in the standard documents directory instead.
Fixes #10014