Skip to content

fix(android): handle exceptions when creating a new session - #10667

Merged
thomaseizinger merged 3 commits into
mainfrom
fix/android-catch-session-errors
Oct 21, 2025
Merged

thomaseizinger merged 3 commits into
mainfrom
fix/android-catch-session-errors

Conversation

@thomaseizinger

Copy link
Copy Markdown
Member

The Session.newAndroid constructor can throw an exception. Unfortunately, the Kotlin compiler didn't warn us about that and thus, any errors when creating a new session caused the service process to crash.

We fix this by wrapping the entire thing in a try-catch-finally block.

Resolves: #10289

@vercel

vercel Bot commented Oct 21, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
firezone Ready Ready Preview Comment Oct 21, 2025 4:05am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@thomaseizinger
thomaseizinger added this pull request to the merge queue Oct 21, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@thomaseizinger
thomaseizinger added this pull request to the merge queue Oct 21, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@thomaseizinger
thomaseizinger added this pull request to the merge queue Oct 21, 2025
Merged via the queue into main with commit 66fcf87 Oct 21, 2025
27 checks passed
@thomaseizinger
thomaseizinger deleted the fix/android-catch-session-errors branch October 21, 2025 21:09

This branch was successfully deployed

1 active deployment
Preview — 31fa7d00 Deployed Oct 21, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android crash in invokeSuspend

2 participants