Skip to content

Conversation

@ReactorScram
Copy link
Contributor

@ReactorScram ReactorScram commented Jul 8, 2024

This would make it a little easier to replicate prod issues on old releases

### Tasks
- [x] Add comment to changelog
- [x] Check Vercel preview
- [x] Request review
- [x] Update arches link
- [x] `apt-get update`
- [x] Re-request review

@ReactorScram ReactorScram self-assigned this Jul 8, 2024
@vercel
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 8:09pm

@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 23 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 231.1 MiB (-2%) 232.4 MiB (-2%) 289 (-2%)
direct-tcp-server2client 241.0 MiB (-0%) 242.6 MiB (-0%) 259 (+2%)
relayed-tcp-client2server 239.4 MiB (+1%) 240.7 MiB (+1%) 458 (+13%)
relayed-tcp-server2client 240.5 MiB (+0%) 241.9 MiB (+0%) 642 (-17%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (+6%) 42.18% (-7%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-25%) 20.40% (-13%)
relayed-udp-client2server 500.0 MiB (+0%) 0.03ms (-50%) 54.52% (-1%)
relayed-udp-server2client 500.0 MiB (+0%) 0.03ms (+42%) 34.48% (+1%)

@ReactorScram ReactorScram marked this pull request as ready for review July 8, 2024 17:01
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the arches we link to for download too in docs and here:

https://github.com/firezone/firezone/blob/main/website/src/components/Changelog/GUI.tsx#L10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need apt-get update && in front of the install commands? I remember hitting an issue due to outdated package lists a while back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It couldn't hurt, I guess. Since we do caching, the update may not always take effect, like doing apt-get update in a Dockerfile, right? Just something to be aware of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we already have apt-get update in that file 🚀

@ReactorScram
Copy link
Contributor Author

The user guide will have a broken link to the arm64 download after this is merged and before the next GUI Client release is cut. Will that be a problem?

@jamilbk
Copy link
Member

jamilbk commented Jul 8, 2024

The user guide will have a broken link to the arm64 download after this is merged and before the next GUI Client release is cut. Will that be a problem?

That should be fine. I'll open a new Pr to bump that in a bit.

@ReactorScram ReactorScram added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit e0326be Jul 8, 2024
@ReactorScram ReactorScram deleted the ci/gui-client-arm branch July 8, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants