-
Notifications
You must be signed in to change notification settings - Fork 385
ci(gui-client/linux): see if we can build the GUI Client for ARM #5793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the arches we link to for download too in docs and here:
https://github.com/firezone/firezone/blob/main/website/src/components/Changelog/GUI.tsx#L10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need apt-get update && in front of the install commands? I remember hitting an issue due to outdated package lists a while back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It couldn't hurt, I guess. Since we do caching, the update may not always take effect, like doing apt-get update in a Dockerfile, right? Just something to be aware of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we already have apt-get update in that file 🚀
|
The user guide will have a broken link to the arm64 download after this is merged and before the next GUI Client release is cut. Will that be a problem? |
That should be fine. I'll open a new Pr to bump that in a bit. |
This would make it a little easier to replicate prod issues on old releases