feat(connlib): allow glob patterns for matching domain names#5901
feat(connlib): allow glob patterns for matching domain names#5901thomaseizinger merged 28 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
a1790c9 to
2739b49
Compare
|
CI currently only fails here because we still have the old DNS resources configured. Unless we want better performance (see #5901 (comment)), I don't think there is anything to do on the Rust side here. |
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
d9826fb to
204c3dd
Compare
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
37c1b9c to
0459b5d
Compare
|
@thomaseizinger this might need rebasing if @AndrewDryga is planning to build off it |
I am one step ahead and did so yesterday 😁 |
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
0459b5d to
c9068fa
Compare
jamilbk
left a comment
jamilbk
left a comment
There was a problem hiding this comment.
We don't update the current versions until after the clients/gateways have been published. Otherwise, they'll point to nonexistent URLs.
scripts/Makefile
Outdated
| current-apple-version = 1.2.0 | ||
| current-android-version = 1.2.0 | ||
| current-gateway-version = 1.2.0 | ||
| current-gui-version = 1.2.0 | ||
| current-headless-version = 1.2.0 |
There was a problem hiding this comment.
| current-apple-version = 1.2.0 | |
| current-android-version = 1.2.0 | |
| current-gateway-version = 1.2.0 | |
| current-gui-version = 1.2.0 | |
| current-headless-version = 1.2.0 | |
| current-apple-version = 1.1.4 | |
| current-android-version = 1.1.5 | |
| current-gateway-version = 1.1.4 | |
| current-gui-version = 1.1.11 | |
| current-headless-version = 1.1.6 |
scripts/Makefile
Outdated
| next-apple-version = 1.2.1 | ||
| next-android-version = 1.2.1 | ||
| next-gateway-version = 1.2.1 | ||
| next-gui-version = 1.2.1 | ||
| next-headless-version = 1.2.1 |
There was a problem hiding this comment.
| next-apple-version = 1.2.1 | |
| next-android-version = 1.2.1 | |
| next-gateway-version = 1.2.1 | |
| next-gui-version = 1.2.1 | |
| next-headless-version = 1.2.1 | |
| next-apple-version = 1.2.0 | |
| next-android-version = 1.2.0 | |
| next-gateway-version = 1.2.0 | |
| next-gui-version = 1.2.0 | |
| next-headless-version = 1.2.0 |
There was a problem hiding this comment.
1.2.0 is not published, so it should be marked as the next version.
There was a problem hiding this comment.
These changes will break all existing links to artifacts.
This PR can't merge unless we bump the versions because the we need the portal to not map the addresses. Can we just not insta-deploy the website? |
Vercel is setup to deploy on merges to Why does the current version need to be changed? Next version is what updates connlib and will make tests pass. With the changes in this PR, |
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
9f59f70 to
f17e0b3
Compare
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
thomaseizinger
force-pushed
the
feat/connlib/glob-address-match
branch
from
f17e0b3 to
0c4d286
Compare
|
| Report | Thu, August 15, 2024 at 01:28:53 UTC |
| Project | Firezone |
| Branch | feat/connlib/glob-address-match |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | Throughput | Throughput Results bits/s | (Δ%) | Throughput Lower Boundary bits/s | (%) |
|---|---|---|---|
| direct-tcp-client2server | ✅ (view plot) | 251,414,508.42 (+3.36%) | 237,627,635.89 (94.52%) |
| direct-tcp-server2client | ✅ (view plot) | 249,013,193.55 (-0.29%) | 241,916,199.42 (97.15%) |
| direct-udp-client2server | ✅ (view plot) | 298,461,425.08 (+3.53%) | 269,979,812.25 (90.46%) |
| direct-udp-server2client | ✅ (view plot) | 405,477,976.48 (+1.56%) | 385,675,850.10 (95.12%) |
| relayed-tcp-client2server | ✅ (view plot) | 240,707,748.40 (-2.41%) | 239,834,714.93 (99.64%) |
| relayed-tcp-server2client | ✅ (view plot) | 260,030,232.07 (+0.59%) | 248,323,903.47 (95.50%) |
| relayed-udp-client2server | ✅ (view plot) | 223,954,189.92 (-2.74%) | 219,396,271.26 (97.96%) |
| relayed-udp-server2client | ✅ (view plot) | 363,155,427.33 (+7.31%) | 318,072,976.43 (87.59%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
3 participants
Currently,
connlibcan only handle "simple" DNS wildcards where*matches any number of subdomains, including zero and?matches a single subdomain.With this PR, we expand
connlib's capabilities to allow for a much more complex matching of domains that more closely resembles glob patterns:**matches any number of subdomains. This supersedes the previous*operator.*matches a single subdomain. This supersedes the previous?operator.?matches a single character. This wasn't possible before.*or?was allowed and they were only accepted at the front of the domain name pattern.Resolves: #5056.