ux(gui-client): remove keyboard accelerators #6017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5953 In all my testing on Windows I've never seen these work. I tried them a couple days ago on Linux and I haven't seen them work there either. No clue why. Tauri bug? Windows bug?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Report | Wed, July 24, 2024 at 14:49:34 UTC |
| Project | Firezone |
| Branch | chore/remove-keyboard-accel |
| Testbed | github-actions |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Throughput (throughput)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Throughput | Throughput Results bits/s |
|---|---|---|
| direct-tcp-client2server | ➖ (view plot) | 238,302,791.24 |
| direct-tcp-server2client | ➖ (view plot) | 243,980,579.04 |
| direct-udp-client2server | ➖ (view plot) | 270,110,982.94 |
| direct-udp-server2client | ➖ (view plot) | 389,464,987.78 |
| relayed-tcp-client2server | ➖ (view plot) | 242,662,693.09 |
| relayed-tcp-server2client | ➖ (view plot) | 259,075,952.53 |
| relayed-udp-client2server | ➖ (view plot) | 234,900,960.89 |
| relayed-udp-server2client | ➖ (view plot) | 348,995,946.77 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
ReactorScram
changed the title
conectado
approved these changes
Jul 24, 2024
Contributor
Author
|
@conectado Should we mention this in the changelog? It's pretty minor and if nobody told us they were broken, then I guess nobody was using them to begin with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5953
Update: It's a known bug in WRY: tauri-apps/wry#451
In all my testing on Windows I've never seen these work. I tried them a couple days ago on Linux and I haven't seen them work there either. No clue why. Tauri bug? Windows bug?