Skip to content

fix(connlib): Disable hickory cache#6143

Merged
jamilbk merged 1 commit intomainfrom
fix/hickory-negative-cache
Aug 2, 2024
Merged

fix(connlib): Disable hickory cache#6143
jamilbk merged 1 commit intomainfrom
fix/hickory-negative-cache

Conversation

@conectado
Copy link
Copy Markdown
Contributor

This seems to fix #6033

What seems to be happening is that sometimes responses are delayed and hickory cache the negative response.

We disable the cache, and the multiple attempts to be as transparent as possible until #6141 is implemented.

Furthermore, the lack of recursion available in responses can cause issues in some clients and enabling it shouldn't cause any problems.

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 4:49am

@jamilbk
Copy link
Copy Markdown
Member

jamilbk commented Aug 2, 2024

CI is hung :-/

Restarting it

@jamilbk jamilbk changed the title fix(connlib): hickory negative cache fix(connlib): Disable hickory cache Aug 2, 2024
@conectado conectado added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@jamilbk jamilbk added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@jamilbk jamilbk added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@jamilbk jamilbk added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@jamilbk jamilbk merged commit abfd378 into main Aug 2, 2024
@jamilbk jamilbk deleted the fix/hickory-negative-cache branch August 2, 2024 06:59
jamilbk added a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS forwarding to upstream resolver occasionally times out

3 participants