feat(headless-client): use systemd-resolved DNS control by default
#6163
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ReactorScram
changed the title
systemd-resolved DNS control by defaultsystemd-resolved DNS control by default
Terraform Cloud Plan Output |
…systemd-default-2
|
| Report | Tue, August 6, 2024 at 17:54:45 UTC |
| Project | Firezone |
| Branch | feat/headless-client/systemd-default-2 |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | Throughput | Throughput Results bits/s | (Δ%) | Throughput Lower Boundary bits/s | (%) |
|---|---|---|---|
| direct-tcp-client2server | ✅ (view plot) | 249,700,612.36 (+3.18%) | 237,050,083.20 (94.93%) |
| direct-tcp-server2client | ✅ (view plot) | 253,414,337.40 (+2.15%) | 241,747,589.94 (95.40%) |
| direct-udp-client2server | ✅ (view plot) | 284,736,688.41 (-1.40%) | 271,591,372.76 (95.38%) |
| direct-udp-server2client | ✅ (view plot) | 397,173,547.79 (+0.30%) | 383,893,263.70 (96.66%) |
| relayed-tcp-client2server | ✅ (view plot) | 250,035,868.90 (+1.64%) | 239,425,819.81 (95.76%) |
| relayed-tcp-server2client | ✅ (view plot) | 257,188,996.58 (-0.07%) | 247,036,035.09 (96.05%) |
| relayed-udp-client2server | ✅ (view plot) | 239,965,359.21 (+4.61%) | 218,841,582.94 (91.20%) |
| relayed-udp-server2client | ✅ (view plot) | 350,347,330.28 (+3.65%) | 318,447,338.36 (90.89%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
| UMask=077 | ||
|
|
||
| Environment="FIREZONE_API_URL=ws://localhost:8081" | ||
| # TODO: Remove after #6163 gets into a release |
There was a problem hiding this comment.
Is there a way we can run the compat tests and integration tests with different parameters or something? Leaving this FIREZONE_DNS_CONTROL var in place means that we're missing out on test coverage for the current version
There was a problem hiding this comment.
We can checkout a different revision of the repository. The question is which one?
There was a problem hiding this comment.
The question is which one?
I think checking out an old revision is going to give us more headaches because it means we can't introduce new things. The point of the compat tests is to ensure we only make backwards-compatible changes.
You can temporarily remove it and see if the integration tests pass. That will give you at least a once-off coverage.
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Nice UX improvement, thank you!
| UMask=077 | ||
|
|
||
| Environment="FIREZONE_API_URL=ws://localhost:8081" | ||
| # TODO: Remove after #6163 gets into a release |
There was a problem hiding this comment.
We can checkout a different revision of the repository. The question is which one?
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Closes #5063, supersedes #5850
Other refactors and changes made as part of this:
from_envfunctions that used to be buried intunnelFIREZONE_DNS_CONTROLis now a regularclapargument again