fix(client): increase mpsc channel size#6184
Merged
ReactorScram merged 4 commits intomainfrom Aug 6, 2024
Merged
Conversation
Refs #5880. This should fix the issue for all practical purposes, but we don't need a channel there, so it does not close the ticket. This affects both the Headless Client and the GUI Client's IPC service.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
| Report | Tue, August 6, 2024 at 16:13:19 UTC |
| Project | Firezone |
| Branch | fix/gui-channel-full-patch |
| Testbed | github-actions |
Click to view all benchmark results
| Benchmark | Throughput | Throughput Results bits/s | (Δ%) | Throughput Lower Boundary bits/s | (%) |
|---|---|---|---|
| direct-tcp-client2server | ✅ (view plot) | 244,906,576.65 (+1.23%) | 237,173,560.66 (96.84%) |
| direct-tcp-server2client | ✅ (view plot) | 250,480,509.79 (+1.02%) | 241,749,120.19 (96.51%) |
| direct-udp-client2server | ✅ (view plot) | 281,070,524.85 (-2.61%) | 271,007,731.32 (96.42%) |
| direct-udp-server2client | ✅ (view plot) | 403,087,601.53 (+1.77%) | 384,051,895.12 (95.28%) |
| relayed-tcp-client2server | ✅ (view plot) | 248,360,217.60 (+0.94%) | 239,772,949.17 (96.54%) |
| relayed-tcp-server2client | ✅ (view plot) | 265,576,468.39 (+3.18%) | 246,909,793.34 (92.97%) |
| relayed-udp-client2server | ✅ (view plot) | 224,309,001.42 (-2.12%) | 218,945,193.61 (97.61%) |
| relayed-udp-server2client | ✅ (view plot) | 339,277,414.01 (+0.42%) | 318,422,064.74 (93.85%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
…zone into fix/gui-channel-full-patch
jamilbk
approved these changes
Aug 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigates #5880.
This should fix the issue for all practical purposes, but we don't need a channel there, so it does not close the ticket. A more permanent fix would involve factoring out the callbacks or cheating and using a Mutex inside the callbacks to do a swap-and-notify thing.
This affects both the Headless Client and the GUI Client's IPC service, on both Linux and Windows.