fix(gui-client): don't delete the log file we're currently writing to #6226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
approved these changes
Aug 9, 2024
| Ok(result?) | ||
| } | ||
|
|
||
| fn choose_logs_to_delete(paths: &[PathBuf]) -> Vec<&Path> { |
Member
There was a problem hiding this comment.
Perhaps the following algorithm would be easier to understand:
- Given a file extension and a path
- List all files in a directory into a
Vec(also filtering byconnlib.) - Sort using
.sort - Pop-off the last one
- Return list
Run call this fn twice, once for .log and once for .jsonl
Contributor
Author
There was a problem hiding this comment.
I know it's premature optimization, but I was thinking this runs in linear time whereas a sort will be super-linear
Member
|
Alternatively, it should be possible to obtain the log file we are writing to from the logger handle. |
conectado
reviewed
Aug 9, 2024
jamilbk
reviewed
Aug 10, 2024
Contributor
Author
Yeah that would be better long-term, especially once #5453 closes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4764