fix(gui-client/windows): allow GUI to run as admin again#6308
fix(gui-client/windows): allow GUI to run as admin again#6308ReactorScram merged 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| # Permissions | ||
|
|
||
| - [ ] Given a production exe, when you run it normally, then it will ask to escalate to Admin privileges ([#2751](https://github.com/firezone/firezone/issues/2751)) |
There was a problem hiding this comment.
These were all out of date too
| const SERVICE_NAME: &str = "firezone_client_ipc"; | ||
| const SERVICE_TYPE: ServiceType = ServiceType::OWN_PROCESS; | ||
|
|
||
| /// Returns true if the IPC service can run properly |
There was a problem hiding this comment.
All this makes the file really long, but adding a refactoring would have made the diff huge.
There's too much IPC service code in firezone-headless-client so I think after this merges we should split that up.
jamilbk
left a comment
jamilbk
left a comment
There was a problem hiding this comment.
I will defer to @thomaseizinger since this is a bit over my head. But does it basically revert the change that was rolled out in 1.1.10?
|
It partially reverts #6176, only affecting Windows. Linux will still get an error in stdout/stderr if you launch the GUI with It also throws an error if the IPC service tries to run as a normal user, since it won't be able to control DNS. Wasn't there one customer who ran into this issue before Thomas did? |
|
And yeah judging from the dates, that did go into 1.1.10 |
Yeah - https://firezonehq.slack.com/archives/C07CL0LSSV8/p1723170052319419 |
Co-authored-by: Thomas Eizinger <thomas@eizinger.io> Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
3 participants
Closes #6305 too
I couldn't find the ticket for this so I'm not sure which customers are affected.