fix(rust/gui-client): ignore network resets before the tunnel is ready#6458
Merged
Conversation
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Co-authored-by: Jamil <jamilbk@users.noreply.github.com> Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Closes #6457 This PR ignores `Session::reset` requests from the GUI while the IPC service is still raising the tunnel. This removes redundant reconnections to the Portal and it may improve behavior on some systems. It's not any faster on my dev laptop. `set_dns` seemed harmless so I didn't touch that.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamilbk
approved these changes
Aug 27, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
ReactorScram
added a commit
that referenced
this pull request
Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6457
This PR ignores
Session::resetrequests from the GUI while the IPC service is still raising the tunnel. This removes redundant reconnections to the Portal and it may improve behavior on some systems.It's not any faster on my dev laptop.
set_dnsseemed harmless so I didn't touch that.