fix(client/windows): put NRPT rules in a special spot if Group Policy is active#6472
fix(client/windows): put NRPT rules in a special spot if Group Policy is active#6472ReactorScram merged 4 commits intomainfrom
Conversation
…up Policy is active Closes #6469
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ReactorScram
changed the title
| if group_policy_key_exists { | ||
| let (key, _) = hklm.create_subkey(group_nrpt_path().join(NRPT_REG_KEY))?; |
There was a problem hiding this comment.
Probably a TOCTOU gap here, if someone is taking the computer off of Group Policy right as we're activating DNS. Worth fixing before merging maybe, but not before testing
There was a problem hiding this comment.
Probably such a low chance it might not be worth the added complexity. I think always having the local key set should mean that it will fall back to that if GPO is disabled?
There was a problem hiding this comment.
Yeah I'll leave it alone for now then and just leave a TODO
| if group_policy_key_exists { | ||
| let (key, _) = hklm.create_subkey(group_nrpt_path().join(NRPT_REG_KEY))?; |
There was a problem hiding this comment.
Probably such a low chance it might not be worth the added complexity. I think always having the local key set should mean that it will fall back to that if GPO is disabled?
2 participants
Closes #6469
DNS deactivation now also uses the registry instead of PowerShell, but this may not be faster, since the latency would already be hidden from users most of the time.