fix(android): Disable DisconnectMonitor while applying changes#6517
Merged
fix(android): Disable DisconnectMonitor while applying changes#6517
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
conectado
approved these changes
Aug 31, 2024
Contributor
conectado
left a comment
conectado
left a comment
There was a problem hiding this comment.
I hate android :( but looks good!
jamilbk
force-pushed
the
fix/android-self-disconnect
branch
from
a6f39f7 to
9ab7f84
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the
DisconnectMonitorwhen callingbuildVpnService()to prevent self-triggered VPN config changes from disconnect the VPN.Other minor cleanups as well.