fix(apple): Don't bold addressDescription in macOS Menubar#6632
Merged
fix(apple): Don't bold addressDescription in macOS Menubar#6632
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ReactorScram
approved these changes
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the addressDescription looks like a URI, we highlight it with markdown and set its click handler to open the URL when clicked. We were also making it bold, which seems to break macOS's menubar width calculation, causing the field to truncate (typically after
https://) instead of expanding the container to contain it.By removing the bold formatting, the container is properly sized, fixing the display issue.
Before
After