fix(rust/gui-client/auth): destroy the connlib session on disconnect#6795
Merged
ReactorScram merged 6 commits intomainfrom Sep 24, 2024
Merged
fix(rust/gui-client/auth): destroy the connlib session on disconnect#6795ReactorScram merged 6 commits intomainfrom
ReactorScram merged 6 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
conectado
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6791
We weren't closing the connlib session immediately when we get
on_disconnect, this patch fixes that.This passes the manual test established in #6792. I also cycled through sign-in, close, open, sign-out, and it looks fine.