fix(rust/client/windows): set our DNS resolvers on our interface#6931
Merged
ReactorScram merged 12 commits intomainfrom Oct 7, 2024
Merged
fix(rust/client/windows): set our DNS resolvers on our interface#6931ReactorScram merged 12 commits intomainfrom
ReactorScram merged 12 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ReactorScram
changed the base branch from
main
to
chore/headless-deactivate-dns-sooner
ReactorScram
commented
Oct 3, 2024
Contributor
Author
There was a problem hiding this comment.
Removed unit tests here that only covered clap's behavior and not our code
Contributor
Author
|
I couldn't get the IPv6 part to work on my dev system, maybe because I don't have IPv6 on this network. It works in CI and it should be harmless even if IPv6 doesn't work. I can test IPv6 when I'm back home Monday. |
thomaseizinger
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6777