fix(rust/gui-client): allow GUI process to read the firezone-id file from disk#6987
Merged
ReactorScram merged 7 commits intomainfrom Oct 9, 2024
Merged
fix(rust/gui-client): allow GUI process to read the firezone-id file from disk#6987ReactorScram merged 7 commits intomainfrom
firezone-id file from disk#6987ReactorScram merged 7 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
changed the title
thomaseizinger
force-pushed
the
chore/better-errors
branch
from
1e0fd2f to
173f9e2
Compare
ReactorScram
changed the title
firezone-id file from disk
Contributor
|
@thomaseizinger I can't mark you for review since it's your PR but I changed a bunch of stuff and it's nearly passing CI. I had a last-minute issue with the smoke test not working |
ReactorScram
approved these changes
Oct 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6989
We attempted to set the tunnel daemon's umask, but this caused the smoke tests to fail. Fixing the regression is more urgent than getting the smoke tests to match local debugging.