chore(rust/gui-client): migrate to Tauri v2#6996
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| }) | ||
| .await | ||
| .context("Failed to join zip export task")??; | ||
| tracing::debug!(elapsed_s = start.elapsed().as_secs(), "Exported logs"); |
There was a problem hiding this comment.
about 7 seconds in debug, about 0 in release, had to check
There was a problem hiding this comment.
Duration has a nicely formatted debug output actually.
…nto chore/tauri-v2-migration
…nto chore/tauri-v2-migration
|
This is ready for early reviews. |
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great work! What a journey :)
| }) | ||
| .await | ||
| .context("Failed to join zip export task")??; | ||
| tracing::debug!(elapsed_s = start.elapsed().as_secs(), "Exported logs"); |
There was a problem hiding this comment.
Duration has a nicely formatted debug output actually.
|
|
||
| if Some(&menu) == self.last_menu_set.as_ref() { | ||
| tracing::debug!("Skipping redundant menu update"); | ||
| } else { |
There was a problem hiding this comment.
An early return would avoid the else.
|
@thomaseizinger Oh yeah should this go after the 1.4.0 Client is cut, so that we have one last Ubuntu 20.04 Client that supports the new protocol? |
That would delay it by at least another 2 weeks. Do we want to hold it for that long? If we decide to do that, we can always backport the new control protocol stuff in a separate release branch for a point release. It is only connlib changes so should be easy :) |
|
Thank you for the good work! Did the team decide to release this before the new 1.4.0 client? would be really useful to my team right now, we have a few devs on the new ubuntu. |
|
@ksparakis Yes I think 2 weeks is too long to wait, we're trying to get this merged soon |
|
@thomaseizinger oh this is probably failing to merge because I deleted Ubuntu 20.04 from the test matrix. Should we force it and then we can update the required tests later? This will affect the Headless Client too, I think we're okay dropping 20.04 support for that too Edit: In standup we agreed on this and Jamil reminded me where the branch protection rules are so I'll update those |
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
There was a problem hiding this comment.
Not sure if we need to rename it when we don't actually going to have two versions of it? Up to you.
| call pnpm tailwindcss -i src\input.css -o src\output.css | ||
|
|
||
| REM bundle JS | ||
| call pnpm vite build |
There was a problem hiding this comment.
I am surprised vite doesn't do the tailwind stuff for you?
There was a problem hiding this comment.
It might. I don't remember exactly why I added vite other than that I want to match the sample Tauri code. So it probably has lots of features I'm not familiar with yet.
|
Great effort on getting this migration done 🚀 |
3 participants
Closes #4883
Refs #7005
Adds support for Ubuntu 24.04, drops support for Ubuntu 20.04
Known issues: