feat(rust/gui-client/windows): sign the IPC service exe#7009
Merged
ReactorScram merged 2 commits intomainfrom Oct 11, 2024
Merged
feat(rust/gui-client/windows): sign the IPC service exe#7009ReactorScram merged 2 commits intomainfrom
ReactorScram merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
conectado
approved these changes
Oct 11, 2024
Comment on lines
+18
to
+20
| <ChangeItem enable={title === "Linux GUI"}> | ||
| This is a maintenance release with no user-facing changes. | ||
| </ChangeItem> |
Contributor
There was a problem hiding this comment.
Maybe we can just skip the changelog?
Contributor
Author
There was a problem hiding this comment.
It's there to fill space since the version number gets bumped on both OSes, right?
Member
|
@ReactorScram Are you cutting a release with this right away? Then I'll still wait with merging #6999. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7008.
We already signed the GUI exe and the entire MSI package, but when adding the IPC service we overlooked that one.
This PR: