-
Notifications
You must be signed in to change notification settings - Fork 395
chore(android): start telemetry together with connlib session #7151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no Rust code / process that runs on Apple / Android until we are starting a connlib session?
| pub const GUI_DSN: Dsn = Dsn("https://2e17bf5ed24a78c0ac9e84a5de2bd6fc@o4507971108339712.ingest.us.sentry.io/4508008945549312"); | ||
| pub const HEADLESS_DSN: Dsn = Dsn("https://bc27dca8bb37be0142c48c4f89647c13@o4507971108339712.ingest.us.sentry.io/4508010028728320"); | ||
| pub const IPC_SERVICE_DSN: Dsn = Dsn("https://0590b89fd4479494a1e7ffa4dc705001@o4507971108339712.ingest.us.sentry.io/4508008896069632"); | ||
| pub const ANDROID_DSN: Dsn = Dsn("https://928a6ee1f6af9734100b8bc89b2dc87d@o4507971108339712.ingest.us.sentry.io/4508175126233088"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be alphabetized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a follow-up.
Correct |
I think there could be! There are a bunch of things, like api-url settings, logger, runtime etc that we could save in a more persistent struct that gets initialised earlier through FFI. That would also give us a place to put the telemetry session earlier and would reduce the number of parameters. On Android, that would make sense because we get loaded as a library only once. On Apple, we are a new process every time so probably not that useful. |
As a first step for integration Sentry into the Android app, we launch the Sentry Rust agent as soon as a
connlibsession starts up. At a later point, we can also integrate Sentry into the Android app itself using the Java / Kotlin SDK.