Skip to content

Conversation

@thomaseizinger
Copy link
Member

As a first step for integration Sentry into the Android app, we launch the Sentry Rust agent as soon as a connlib session starts up. At a later point, we can also integrate Sentry into the Android app itself using the Java / Kotlin SDK.

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:51pm

Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
Copy link
Contributor

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no Rust code / process that runs on Apple / Android until we are starting a connlib session?

pub const GUI_DSN: Dsn = Dsn("https://2e17bf5ed24a78c0ac9e84a5de2bd6fc@o4507971108339712.ingest.us.sentry.io/4508008945549312");
pub const HEADLESS_DSN: Dsn = Dsn("https://bc27dca8bb37be0142c48c4f89647c13@o4507971108339712.ingest.us.sentry.io/4508010028728320");
pub const IPC_SERVICE_DSN: Dsn = Dsn("https://0590b89fd4479494a1e7ffa4dc705001@o4507971108339712.ingest.us.sentry.io/4508008896069632");
pub const ANDROID_DSN: Dsn = Dsn("https://928a6ee1f6af9734100b8bc89b2dc87d@o4507971108339712.ingest.us.sentry.io/4508175126233088");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be alphabetized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in a follow-up.

@jamilbk
Copy link
Member

jamilbk commented Oct 24, 2024

Is there no Rust code / process that runs on Apple / Android until we are starting a connlib session?

Correct

@thomaseizinger
Copy link
Member Author

Is there no Rust code / process that runs on Apple / Android until we are starting a connlib session?

I think there could be! There are a bunch of things, like api-url settings, logger, runtime etc that we could save in a more persistent struct that gets initialised earlier through FFI. That would also give us a place to put the telemetry session earlier and would reduce the number of parameters.

On Android, that would make sense because we get loaded as a library only once. On Apple, we are a new process every time so probably not that useful.

@thomaseizinger thomaseizinger added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 5cf105f Oct 24, 2024
98 of 101 checks passed
@thomaseizinger thomaseizinger deleted the feat/android-sentry-integration branch October 24, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants