fix(connlib): reconnect in case we lose all relays #7164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
force-pushed
the
fix/reconnect-portal-no-relays
branch
2 times, most recently
from
9e9d396 to
e3e8eb7
Compare
thomaseizinger
commented
Oct 28, 2024
Member
Author
There was a problem hiding this comment.
In these tests, we don't add any relays and thus they can't succeed. The only thing they really test are timeouts which I couldn't be bothered to make work 😅
thomaseizinger
force-pushed
the
fix/reconnect-portal-no-relays
branch
from
e3e8eb7 to
f953a01
Compare
thomaseizinger
force-pushed
the
fix/reconnect-portal-no-relays
branch
from
f953a01 to
6602e7a
Compare
thomaseizinger
force-pushed
the
fix/reconnect-portal-no-relays
branch
from
6602e7a to
843680b
Compare
thomaseizinger
force-pushed
the
fix/reconnect-portal-no-relays
branch
from
843680b to
7b093b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During normal operation, we should never lose connectivity to the set of assigned relays in a client or gateway. In the presence of odd network conditions and partitions however, it is possible that we disconnect from a relay that is in fact only temporarily unavailable. Without an explicit mechanism to retrieve new relays, this means that both clients and gateways can end up with no relays at all. For clients, this can be fixed by either roaming or signing out and in again. For gateways, this can only be fixed by a restart!
Without connected relays, no connections can be established. With #7163, we will at least be able to still establish direct connections. Yet, that isn't good enough and we need a mechanism for restoring full connectivity in such a case.
We creating a new connection, we already sample one of our relays and assign it to this particular connection. This ensures that we don't create an excessive amount of candidates for each individual connection. Currently, this selection is allowed to be silently fallible. With this PR, we make this a hard-error and bubble up the error that all the way to the client's and gateway's event-loop. There, we initiate a reconnect to the portal as a compensating action. Reconnecting to the portal means we will receive another
initmessage that allows us to reconnect the relays.Due to the nature of this implementation, this fix may only apply with a certain delay from when we actually lost connectivity to the last relay. However, this design has the advantage that we don't have to introduce an additional state within
snownet: Connections now simply fail to establish and the next one soon after should succeed again because we will have received a newinitmessage.Resolves: #7162.