fix(connlib): don't attempt to encrypt too large packets#7263
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
force-pushed
the
fix/no-panic-too-large-packets
branch
from
5f6d535 to
d7c7190
Compare
jamilbk
reviewed
Nov 5, 2024
jamilbk
reviewed
Nov 5, 2024
jamilbk
reviewed
Nov 5, 2024
jamilbk
reviewed
Nov 5, 2024
jamilbk
reviewed
Nov 5, 2024
jamilbk
approved these changes
Nov 5, 2024
Co-authored-by: Jamil <jamilbk@users.noreply.github.com> Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encrypting packets, we need to reserve a buffer within which boringtun will encrypt the IP packet. Unfortunately,
boringtunpanics if that buffer is not big enough which essentially brings all ofconnlibdown.Really, we should never see a packet that is too large and ideally, we enforce this at compile-time by creating different variants of
IpPacketthat are sized accordingly. That is a large refactoring so until then, we simply discard them instead of panicking.