fix(connlib): apply timeout to WebSocket connection to portal - #7265
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
changed the title
thomaseizinger
marked this pull request as ready for review
November 5, 2024 05:51
thomaseizinger
enabled auto-merge
November 5, 2024 06:08
jamilbk
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in #7254 and #7200 appears to be that eventually, we fail to connect to the portal because we stop re-trying, i.e. the socket connect appears to hang forever. Perhaps there is race condition somewhere in how we resolve DNS / flush DNS servers etc. Regardless of that, connecting to the portal should never take more than 5s so timing out after that ensures we retry the connection.
Resolves: #7254.
Resolves: #7200.