fix(connlib): don't fail NAT64 on invalid IPv4 DSCP value#7479
Merged
thomaseizinger merged 2 commits intomainfrom Dec 11, 2024
Merged
fix(connlib): don't fail NAT64 on invalid IPv4 DSCP value#7479thomaseizinger merged 2 commits intomainfrom
thomaseizinger merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
I'll close it once it is deployed to |
jamilbk
approved these changes
Dec 11, 2024
Member
jamilbk
left a comment
jamilbk
left a comment
There was a problem hiding this comment.
Interesting, nice to see this working in action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the RFC, the IPv6 traffic class should be 1-to-1 translated to the IPv4 DSCP value. However, it appears that not all values here are valid. In particular, when attempting to reach GitHub over IPv6, we receive an IPv6 packet that has a traffic class value of 72 which is out-of-range for the IPv4 DSCP value, resulting in the following error on the Gateway:
The bigger scope of this issue is that this causes the ICMP packets returned to the client to be dropped which means that
sshspawned bygitdoesn't learn that the IPv6 address assigned by Firezone is not actually routable.Related: #7476.