fix(apple): Don't crash if tunnel manager session is unexpectedly nil#7594
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamilbk
force-pushed
the
fix/load-tunnel-manager
branch
from
2e49c44 to
2faab4c
Compare
jamilbk
force-pushed
the
fix/nil-tunnel-session
branch
from
1d58d3c to
8c9f426
Compare
thomaseizinger
approved these changes
Dec 30, 2024
Co-authored-by: Thomas Eizinger <thomas@eizinger.io> Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain weird edge cases such as:
NETunnelProviderSessionto go invalid immediatelythen the TunnelManager will not be able to obtain a valid reference to a NETunnelProviderSession object.
In these cases, for now, it makes more sense to fail silently than to crash, effectively making these operations a no-op until the user remedies the VPN profile. Currently the user is prompted to re-grant VPN profile whenever its status goes to
invalid, so these cases don't technically fail without prompting the user.Draft because it's stacked on #7593
Fixes #7579
Fixes #7591