fix(gui-client): don't fail on missing update-desktop-database#7822
Merged
Conversation
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Good find. This should presumably alleviate issues with RPM-based distros right? Would it be worth adding a changelog entry for it? |
jamilbk
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the GUI Client exits if
update-desktop-databasecannot be executed after deep-links were registered. On non-Ubuntu systems (or more generally non-Debian) this will fail since the command does not exist and prevent the GUI Client from starting.This PR just ignores any command-not-found error, ensuring the command still has to succeed on Debian/Ubuntu machines.