fix(apple): Fix memory leak in pathUpdateHandler#7890
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamilbk
commented
Jan 28, 2025
Member
Author
There was a problem hiding this comment.
Most of this is just moving the didReceivePathUpdate function body to the closure directly.
jamilbk
changed the title
thomaseizinger
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
didReceivePathUpdateprivate function, we capture an implicit hard reference toselfbecause we access theAdapterinstance properties. This function is called in the workQueue by the NWPathMonitor API and as such, we should weakly capture self throughout to prevent a retain cycle.To fix this, we use a
lazy varfor thepathUpdateHandlerclosure, capturing[weak self]within it to use throughout the remainder of the callback.