You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of fixing #6777, we added a code path to explicitly set nameservers on the tunnel interface. This was necessary to make DNS resources work under WSL. Exactly this code also seems to be causing issues where this particular registry key is not available on a users machine.
DNS resources outside of WSL will also work without this, therefore we make this part optional to at least have something working on the users machine.
I am a bit hesitant on this "fix" because I'd like to first understand, why the registry key doesn't exist but the adapter is supposedly up? That seems like a state we should never get ourselves into.
I tested this in my VM and regular DNS still works (as expected). Might be worth merging as a hotfix. I also tested with the code commented out and it also works, i.e. on machines where this is failing, not executing it should still give you access to DNS resources (at least in the browser etc).
I also tested this with WSL and it seems to work so I am not even sure why we are setting these nameservers at all?
To confirm: I tested with the code commented out! So something else must have changed because that would mean #6777 was never an issue?
Perhaps a recent Windows / WSL update changed the behavior here (or fixed it). I do remember in that issue specifically the patch fixed the issue for the particular customer(s).
Base automatically changed from
fix/nrpt-rule-apply-failed to
mainFebruary 1, 2025 21:29
Adds changelog entries for #7972 and #8003. Bundled together to avoid
merge conflicts.
---------
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Jamil <jamilbk@users.noreply.github.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thomaseizinger
force-pushed
the
fix/apply-nameservers-optional
branch
from
As part of fixing #6777, we added a code path to explicitly set nameservers on the tunnel interface. This was necessary to make DNS resources work under WSL. Exactly this code also seems to be causing issues where this particular registry key is not available on a users machine.
DNS resources outside of WSL will also work without this, therefore we make this part optional to at least have something working on the users machine.
Related: #7962.