Skip to content

fix(apple): Don't try to sign in if user cancels - #7996

Merged
jamilbk merged 1 commit into
mainfrom
fix/web-auth-alert
Feb 3, 2025
Merged

fix(apple): Don't try to sign in if user cancels#7996
jamilbk merged 1 commit into
mainfrom
fix/web-auth-alert

Conversation

@jamilbk

@jamilbk jamilbk commented Feb 2, 2025

Copy link
Copy Markdown
Member

This fixes a minor regression introduced in f779fe9 where we would incorrectly show an error dialog if the user cancels sign in because the authResponse is invalid.

@vercel

vercel Bot commented Feb 2, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 5:53pm

@jamilbk
jamilbk added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 6842e04 Feb 3, 2025
@jamilbk
jamilbk deleted the fix/web-auth-alert branch February 3, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants