Skip to content

feat(gui-client): gracefully exit GUI on graceful IPC shutdown#8035

Merged
thomaseizinger merged 4 commits into
mainfrom
chore/graceful-gui-shutdown
Feb 10, 2025
Merged

feat(gui-client): gracefully exit GUI on graceful IPC shutdown#8035
thomaseizinger merged 4 commits into
mainfrom
chore/graceful-gui-shutdown

Conversation

@thomaseizinger

@thomaseizinger thomaseizinger commented Feb 6, 2025

Copy link
Copy Markdown
Member

When the IPC service gets terminated gracefully, the user must have initiated some kind of action, be it an upgrade or an explicit "Stop the service". In that case, there is no point in displaying an alert with an info / error message as the user already knows that they are stopping Firezone. In order to not fatigue the user with alerts, we exit the GUI with a toast notification when the IPC service shuts down gracefully. Toast notifications do not grab the users attention, allowing them to continue what they are doing while still being notified that their Firezone client is now disconnected.

Fixes: #6232.

@vercel

vercel Bot commented Feb 6, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 3:19am

@thomaseizinger

Copy link
Copy Markdown
Member Author

@jamilbk Instead of a silent exit, I could also display a toast notification similar to what we say with "Firezone connected". Something like "Firezone disconnected, please restart the client to gain access to your resources.".

Thoughts? It may be surprising to users that the GUI disappears silently, especially because it only lives in the tray menu.

@jamilbk

jamilbk commented Feb 6, 2025

Copy link
Copy Markdown
Member

@jamilbk Instead of a silent exit, I could also display a toast notification similar to what we say with "Firezone connected". Something like "Firezone disconnected, please restart the client to gain access to your resources.".

Thoughts? It may be surprising to users that the GUI disappears silently, especially because it only lives in the tray menu.

Yeah probably a good idea. "Firezone client detected IPC service shutdown. Quitting..." or similar.

@thomaseizinger thomaseizinger changed the title feat(gui-client): silently exit on graceful shutdown feat(gui-client): gracefully exit GUI on graceful IPC shutdown Feb 10, 2025
@thomaseizinger thomaseizinger force-pushed the chore/graceful-gui-shutdown branch from 412f75d to ad51310 Compare February 10, 2025 01:55
@thomaseizinger

Copy link
Copy Markdown
Member Author

It works!

image

@thomaseizinger

Copy link
Copy Markdown
Member Author

Fixes: #6232.

Just tested and this also fixes the above linked issue.

@thomaseizinger thomaseizinger added this pull request to the merge queue Feb 10, 2025
@thomaseizinger thomaseizinger removed this pull request from the merge queue due to a manual request Feb 10, 2025
@thomaseizinger thomaseizinger added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit fdb7631 Feb 10, 2025
@thomaseizinger thomaseizinger deleted the chore/graceful-gui-shutdown branch February 10, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ux(gui-client): Uninstalling Firezone while signed in results in IPC disconnected error dialog

2 participants