fix(apple): Prevent dupe resources timer scheduling#8066
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamilbk
changed the title
thomaseizinger
approved these changes
Feb 9, 2025
| func beginUpdatingResources(callback: @escaping (ResourceList) -> Void) { | ||
| Log.log("\(#function)") | ||
|
|
||
| guard self.resourcesTimer == nil |
Member
There was a problem hiding this comment.
It seems weird to me to use a guard without actually creating a new variable that holds the state you are guarding. If you don't need the resource timer, just make it an if != nil.
|
Sentry Issue: APPLE-CLIENT-29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we receive two
.connectedstatus change updates from the system in a row, we'll incorrectly schedule an additional timer, and the handle to the first one will be lost.This causes a memory leak because we'll then never call the first timer's
invalidate()function in theendUpdatingResourcescall.