fix(rust): only use ANSI colors if the output supports it#8070
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
force-pushed
the
fix/no-ansi-windows-headless
branch
from
628d129 to
dfefb46
Compare
thomaseizinger
commented
Feb 10, 2025
| let log_path = known_dirs::logs().context("Can't compute app log dir")?; | ||
|
|
||
| // Logfilter for stderr cannot be reloaded. This is okay because we are using it only for local dev and debugging anyway. | ||
| // Logfilter for stdout cannot be reloaded. This is okay because we are using it only for local dev and debugging anyway. |
Member
Author
There was a problem hiding this comment.
Digging into tracing, i realised our default is actually stdout! I'll make a follow-up to change to stderr.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8054.