Skip to content

fix(gui-client): migrate to tailwind v4#8105

Merged
thomaseizinger merged 4 commits into
mainfrom
fix/visual-regression
Feb 12, 2025
Merged

fix(gui-client): migrate to tailwind v4#8105
thomaseizinger merged 4 commits into
mainfrom
fix/visual-regression

Conversation

@thomaseizinger

Copy link
Copy Markdown
Member

With the dependency bump in #7995, we introduced a visual regression that made all windows lose their styling:

image

The changelog to the v4 bump actually mentions some breaking changes and an automated upgrade tool but both the reviewer and the author of the PR missed that.

@vercel

vercel Bot commented Feb 11, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:07am

@thomaseizinger

Copy link
Copy Markdown
Member Author

Waiting for CI to build a release binary for both Ubuntu and Windows to test.

@jamilbk jamilbk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, that's a slip up on my part. We did the same upgrade for the portal and didn't hit these issues.

I'm assuming this is now verified to look as before?

@jamilbk

jamilbk commented Feb 11, 2025

Copy link
Copy Markdown
Member

Oh no, that's a slip up on my part. We did the same upgrade for the portal and didn't hit these issues.

I'm assuming this is now verified to look as before?

Actually we haven't upgraded in the portal yet. We'll have a similar fun time it looks like:

phoenixframework/tailwind#106

@thomaseizinger

Copy link
Copy Markdown
Member Author

I'm assuming this is now verified to look as before?

Checking the artifacts now.

@thomaseizinger

Copy link
Copy Markdown
Member Author

Looks good on Windows:

image

@jamilbk

jamilbk commented Feb 12, 2025

Copy link
Copy Markdown
Member

I'm assuming this is now verified to look as before?

Checking the artifacts now.

Thanks! I had originally set up the dev scripts so that it was easy to do the frontend dev on non-tauri platforms like macOS, but it looks like they've regressed since then. Would be helpful to get on a short call in the next couple days to see your workflow (or maybe just an updated section in README).

@thomaseizinger

Copy link
Copy Markdown
Member Author

I'm assuming this is now verified to look as before?

Checking the artifacts now.

Thanks! I had originally set up the dev scripts so that it was easy to do the frontend dev on non-tauri platforms like macOS, but it looks like they've regressed since then. Would be helpful to get on a short call in the next couple days to see your workflow (or maybe just an updated section in README).

I just download the artifacts built in CI and install them in VMs. Not the quickest turnaround but gives me the most confidence on what the release binary will actually look like.

@thomaseizinger

Copy link
Copy Markdown
Member Author

Same on Ubuntu:
image

@thomaseizinger
thomaseizinger added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 5a12dcb Feb 12, 2025
@thomaseizinger
thomaseizinger deleted the fix/visual-regression branch February 12, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants