fix(apple): don't panic in FFI functions#8202
Merged
Merged
Conversation
We now report this on the Swift side.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sentry Issue: APPLE-CLIENT-2N |
|
Sentry Issue: APPLE-CLIENT-2P |
thomaseizinger
enabled auto-merge
February 19, 2025 21:50
jamilbk
reviewed
Feb 19, 2025
| session?.setDns(jsonResolvers) | ||
| do { | ||
| session?.setDns(jsonResolvers) | ||
| } catch let error { |
Member
There was a problem hiding this comment.
Suggested change
| } catch let error { | |
| } catch { |
error is already provided
Member
Author
There was a problem hiding this comment.
Where? I just copied this from another do catch block. Is error implicitly defined within a catch?
Member
There was a problem hiding this comment.
Yeah, it is - that one must have been leftover from Earlier Times™
| session?.setDisabledResources(toSet) | ||
| do { | ||
| session?.setDisabledResources(toSet) | ||
| } catch let error { |
Member
There was a problem hiding this comment.
Suggested change
| } catch let error { | |
| } catch { |
jamilbk
approved these changes
Feb 19, 2025
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
jamilbk
enabled auto-merge
February 19, 2025 23:19
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Now that we have error reporting via Sentry in Swift-land as well, we can handle errors in the FFI layer more gracefully and return them to Swift. --------- Signed-off-by: Jamil <jamilbk@users.noreply.github.com> Co-authored-by: Jamil <jamilbk@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have error reporting via Sentry in Swift-land as well, we can handle errors in the FFI layer more gracefully and return them to Swift.