Skip to content

fix(apple): web auth session mem leak#8237

Merged
jamilbk merged 1 commit intomainfrom
fix/web-auth-session-circ-ref
Feb 24, 2025
Merged

fix(apple): web auth session mem leak#8237
jamilbk merged 1 commit intomainfrom
fix/web-auth-session-circ-ref

Conversation

@jamilbk
Copy link
Copy Markdown
Member

@jamilbk jamilbk commented Feb 24, 2025

We had a very small memory leak due to a circular reference in the WebAuthSession class.

Screenshot 2025-02-23 at 7 00 50 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 3:06am

@jamilbk jamilbk changed the title fix(apple): web auth session circ ref fix(apple): web auth session mem leak Feb 24, 2025
Copy link
Copy Markdown
Member

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Probably worth a release together with the crash fix and the state simplification.

@jamilbk jamilbk added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit b9c0ba9 Feb 24, 2025
@jamilbk jamilbk deleted the fix/web-auth-session-circ-ref branch February 24, 2025 03:43
@sentry
Copy link
Copy Markdown

sentry Bot commented Feb 24, 2025

Sentry Issue: APPLE-CLIENT-19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants