Skip to content

fix(apple): Pass menuBar to AppView#8249

Merged
jamilbk merged 2 commits into
mainfrom
fix/menuBar-env
Feb 24, 2025
Merged

fix(apple): Pass menuBar to AppView#8249
jamilbk merged 2 commits into
mainfrom
fix/menuBar-env

Conversation

@jamilbk

@jamilbk jamilbk commented Feb 24, 2025

Copy link
Copy Markdown
Member

A regression was introduced in #8218 that removed the menuBar as an environment object for AppView.

Unfortunately this compiles just fine, as EnvironmentObjects are loaded at runtime, causing the "Open Menu" button to crash since it's looking for a non-existent EnvironmentObject.

@vercel

vercel Bot commented Feb 24, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 6:06pm

@sentry

sentry Bot commented Feb 24, 2025

Copy link
Copy Markdown

Sentry Issue: APPLE-CLIENT-2V

@jamilbk jamilbk disabled auto-merge February 24, 2025 18:44
@jamilbk jamilbk merged commit cf837a3 into main Feb 24, 2025
@jamilbk jamilbk deleted the fix/menuBar-env branch February 24, 2025 18:44
@sentry

sentry Bot commented Feb 24, 2025

Copy link
Copy Markdown

Sentry Issue: APPLE-CLIENT-2W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant