fix(connlib): Emit resources updated when display fields change#8286
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jamilbk
force-pushed
the
fix/connlib-on-update
branch
from
ba0b9e1 to
c227ac3
Compare
Member
Author
|
Tested on iOS/macOS by individually changing each of: |
thomaseizinger
approved these changes
Feb 27, 2025
thomaseizinger
left a comment
thomaseizinger
left a comment
Member
There was a problem hiding this comment.
LGTM
Left a suggestion to make the control-flow easier to reason about.
thomaseizinger
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a Resource's name, address_description, or assigned sites change, it is not currently reflected in clients. For that to happen the address is changed.
This PR updates that behavior so that if any display fields are changed, the
on_update_resourcescallback is called which properly updates the resource list views in clients.Fixes #8284