Skip to content

fix(android): Ensure Android layouts fitsSystemWindows#8376

Merged
jamilbk merged 2 commits intomainfrom
fix/android-layout
Mar 6, 2025
Merged

fix(android): Ensure Android layouts fitsSystemWindows#8376
jamilbk merged 2 commits intomainfrom
fix/android-layout

Conversation

@jamilbk
Copy link
Copy Markdown
Member

@jamilbk jamilbk commented Mar 6, 2025

  • Sets the fitsSystemWindows var to avoid overlapping any system controls
  • Makes all margin padding consistent at @dimen/spacing_medium so that no controls are right on the edge of the view

Fixes: https://firezonehq.slack.com/archives/C08FPHECLUF/p1741266356394749
Fixes: #7094

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 2:34pm

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

@jamilbk jamilbk enabled auto-merge March 6, 2025 14:32
@jamilbk
Copy link
Copy Markdown
Member Author

jamilbk commented Mar 6, 2025

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

GitHub, you're fired

@thomaseizinger
Copy link
Copy Markdown
Member

Ah nice! Ironically, I just read about this this morning and thought "I should fix that stupid layout bug on Android" (#7094).

Thanks for dealing with it!

@jamilbk jamilbk added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit cb0283f Mar 6, 2025
124 checks passed
@jamilbk jamilbk deleted the fix/android-layout branch March 6, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings screen on Android 15 is bugged

3 participants