fix(connlib): Update search_domain for exsiting TunConfigs#8445
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
Tested manually; fixes the issue. Will merge in support of #8442 |
| existing.ip.v6 = config.ipv6; | ||
|
|
||
| // These are safe to always update | ||
| existing.search_domain = config.search_domain.clone(); |
Member
There was a problem hiding this comment.
I am not sure if this is enough, we probably also need to check in maybe_update_tun_config to actually push it to the host app? We should test this as well in the proptests.
Member
Author
There was a problem hiding this comment.
You were right - update_dns_mapping is a no-op if the upstream resolvers don't change.
I tested manually extensively in #8452 which, although ugly, works robustly.
Member
Author
There was a problem hiding this comment.
It was very painful working through a few failed refactors to get to that PR 🙃. Lots of complexity I see what you mean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For existing
TunConfig, we had a bug where we failed to update the search_domain if the effective dns_servers were unchanged.@thomaseizinger I can see why you want to refactor this; it's quite a mess to follow ;-). I was going to try my hand at cleaning it up a little bit just so I can grok it but I figured since this area is going to be changing quite a bit in #8263, I'll leave those changes out for now.