fix(gateway): default to 1 TUN thread on single-core systems#8765
Merged
thomaseizinger merged 4 commits intomainfrom Apr 13, 2025
Merged
fix(gateway): default to 1 TUN thread on single-core systems#8765thomaseizinger merged 4 commits intomainfrom
thomaseizinger merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
rust/gateway/src/main.rs:282
- Consider adding a validation check in the FromStr implementation for NumThreads to ensure the parsed thread count is non-zero. Passing 0 might cause runtime issues when initializing the TUN device manager.
Ok(Self(s.parse()?))
jamilbk
approved these changes
Apr 13, 2025
Member
|
Good call on Changelog entry! |
Member
Author
|
Note that this is for the Gateway only. On Linux clients, we will always default to 2 TUN threads. I guess it is unlikely that we run the Linux client on a system with only a single CPU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On single-core systems, spawning more than one TUN thread results in contention that hurts performance more than it helps.
Resolves: #8760