fix(connlib): ensure ICE timing config applies immediately#9014
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ICE timing issue by ensuring the new timer configuration applies immediately by switching to a fork of str0m that clears internal caches more promptly.
- Updated dependency for str0m in Cargo.toml to point to the fork with the necessary fixes.
Member
Author
|
I tested this locally (was only reproducible if you have a single candidate pair, i.e. what usually happens with relayed connections). It is unit-tested in str0m which is why I didn't add an additional test here in Firezone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is no traffic going through the tunnel, Firezone switches into a low-power mode where it only sends STUN bindings every 60s. As soon as we see traffic, we move out of this low-power mode to detect connectivity problems early.
Applying this new timing config however does not clear some internal caches in
str0mand therefore, it can take up to the previously set timeout value until str0m actually picks up on the new timers.This is being fixed in algesten/str0m#649. Until that is merged, we depend on our fork that has these changes merged already.
Resolves: #8999