fix(connlib): take into account header overhead for GSO#9088
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Sentry Issue: GATEWAY-CG |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the UDP payload size calculation to account for the IP and UDP header overhead in scenarios involving Generic Segmentation Offload (GSO).
- Updated the calculate_chunk_size function to include the destination SocketAddr parameter for header overhead calculations.
- Adjusted the maximum payload calculation by subtracting the appropriate header lengths based on IP version.
|
Sentry Issue: GATEWAY-CD |
jamilbk
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating the maximum size of the UDP payload we can send in a single syscall, we need to take into account the overhead of the IP and UDP headers.