feat(gui-client): rename IPC service to Tunnel service#9154
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames references from "IPC service" to "Tunnel service" to better reflect the service’s role in managing the tunnel control for the GUI client. Key changes include updating comments, error messages, and build scripts to reflect the new service name.
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/gui-client/src-tauri/src/lib.rs | Updated comments to reference Tunnel service |
| rust/gui-client/src-tauri/src/ipc/windows.rs | Updated inline comments from IPC to Tunnel service |
| rust/gui-client/src-tauri/src/ipc/linux.rs | Updated documentation comments to reference Tunnel |
| rust/gui-client/src-tauri/src/ipc.rs | Updated error messages and test comments accordingly |
| rust/gui-client/src-tauri/src/gui/system_tray.rs | Updated comments to reflect the new service naming |
| rust/gui-client/src-tauri/src/elevation.rs | Updated comments to mention Tunnel services |
| rust/gui-client/src-tauri/src/deep_link.rs | Updated comments to reference Tunnel service |
| rust/gui-client/src-tauri/src/controller.rs | Updated logging messages and notifications |
| rust/gui-client/src-tauri/src/clear_logs.rs | Updated inline comments to reflect Tunnel service |
| rust/gui-client/src-tauri/rpm_files/firezone-gui-client.spec | Updated binary and file paths for the Tunnel service |
| rust/gui-client/src-tauri/deb_files/prerm | Updated service name in the pre-removal script |
| rust/gui-client/src-tauri/deb_files/postinst | Updated service name in the post-installation script |
| rust/gui-client/src-tauri/deb_files/firezone-tunnel-service.service | Updated service configuration details |
| rust/gui-client/docs/manual_testing.md | Updated test cases to refer to Tunnel service |
| rust/gui-client/build.sh | Updated build script paths and comments |
| rust/client-shared/src/callbacks.rs | Updated documentation comments to reference Tunnel service |
| rust/bin-shared/src/known_dirs/windows.rs | Updated inline comments describing service config paths |
| rust/bin-shared/src/known_dirs/linux.rs | Updated inline comments describing service config paths |
| rust/bin-shared/src/dns_control.rs | Updated TODO comments to reference Tunnel service |
| rust/bin-shared/src/device_id.rs | Updated error context message for service config paths |
Comments suppressed due to low confidence (1)
rust/gui-client/src-tauri/src/ipc.rs:32
- The error message now refers to an IPC socket instead of a Tunnel service. Consider if this terminology should be updated further for consistency with the new naming convention.
#[error("Couldn't find IPC socket `{0}`")]
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
from
c954424 to
22bb8c7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
3 times, most recently
from
eed1009 to
afdf2bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
from
afdf2bc to
be42257
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
from
8d7769a to
664f909
Compare
jamilbk
left a comment
jamilbk
left a comment
There was a problem hiding this comment.
Isn't this a breaking change? What will happen to the old files on disk?
See all the changes I am making to the install scripts. I've already tested Ubuntu and Windows and the new installer scripts handle the rename gracefully and successfully. Old files no longer listed in a package are automatically removed by package managers. Still need to test rpm but I don't have a VM for that yet ... |
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
from
126d925 to
40ddad8
Compare
|
Final test binaries: https://github.com/firezone/firezone/actions/runs/15109205410 |
thomaseizinger
force-pushed
the
chore/rename-ipc-service
branch
from
17efc96 to
65e90e1
Compare
|
@oddlama FYI: With the next release of the GUI client (1.4.14), the background service binary changes names which likely affects the Nix package. Nothing else changes though so should be pretty easy. |
|
Thanks for the heads-up! Will keep that in mind |
The name IPC service is not very descriptive. By nature of being separate processes, we need to use IPC to communicate between them. The important thing is that the service process has control over the tunnel. Therefore, we rename everything to "Tunnel service".
The only part that is not changed are historic changelog entries.
Resolves: #9048