feat(gui-client): polish Linux bundling - #9181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thomaseizinger
changed the title
rpm bundlerdeb and rpm bundler
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
thomaseizinger
force-pushed
the
chore/use-tauri-rpm
branch
from
May 19, 2025 23:40
07fdf15 to
f16458e
Compare
thomaseizinger
changed the title
deb and rpm bundler
thomaseizinger
commented
May 20, 2025
thomaseizinger
commented
May 20, 2025
Comment on lines
-68
to
-73
| 5. `sudo systemctl enable firezone-client-tunnel.service` (See | ||
| https://www.freedesktop.org/software/systemd/man/latest/systemd.preset.html, | ||
| "It is not recommended to ship preset files within the respective software | ||
| packages implementing the units". The Fedora family of distros also seem to | ||
| have their own policy that installing a service should not auto-start or | ||
| enable it.) |
Member
Author
There was a problem hiding this comment.
I've dropped this for consistency with our Debian package. Our service just idles anyway unless a GUI connects so this doesn't seem like a big problem to me and will make things easier for most users.
thomaseizinger
commented
May 20, 2025
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
thomaseizinger
commented
May 20, 2025
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
thomaseizinger
commented
May 20, 2025
| "/usr/lib/sysusers.d/firezone-client-tunnel.conf": "./deb_files/sysusers.conf" | ||
| "/usr/lib/systemd/system/firezone-client-tunnel.service": "./linux_package/firezone-client-tunnel.service", | ||
| "/usr/lib/sysusers.d/firezone-client-tunnel.conf": "./linux_package/sysusers.conf", | ||
| "/usr/bin/firezone-client-tunnel": "../../target/release/firezone-client-tunnel" |
Member
Author
There was a problem hiding this comment.
The tunnel service binary is now embedded as a regular file. This means the bundling will only work for release builds but we never make bundles of the debug build anyway.
thomaseizinger
commented
May 20, 2025
thomaseizinger
marked this pull request as ready for review
May 20, 2025 05:25
Member
Author
|
Tested both |
thomaseizinger
enabled auto-merge
May 20, 2025 07:56
jamilbk
approved these changes
May 20, 2025
| "/usr/lib/sysusers.d/firezone-client-tunnel.conf": "./deb_files/sysusers.conf" | ||
| "/usr/lib/systemd/system/firezone-client-tunnel.service": "./linux_package/firezone-client-tunnel.service", | ||
| "/usr/lib/sysusers.d/firezone-client-tunnel.conf": "./linux_package/sysusers.conf", | ||
| "/usr/bin/firezone-client-tunnel": "../../target/release/firezone-client-tunnel" |
This was referenced May 20, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tauri's
debandrpmbundler have support for configuring maintainer scripts. We can therefore just use those instead of tearing apart thedebfile that it creates and rebuilding it ourselves.Our
rpmpackaging is currently completely broken as well. I couldn't get it to work on CentOS 9 at all due to missing dependencies, likely introduced by our move to Tauri v2. It installs fine on CentOS 10 though, assuming that the user has the EPEL repository installed which provides the WebView dependency. I extended the docs to reflect this.Hence, with this PR, we drop support for CentOS 9 and now require CentOS 10. This allows us to remove a lot of cruft from our bundling process and instead entirely rely on the Tauri provided bundler.
Lastly, for consistency with other platforms, the name of the application in places like app drawers has been changed from "Firezone Client" to just "Firezone".